Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show in Finder should be more aware #392

Open
gingerbeardman opened this Issue Apr 4, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@gingerbeardman
Copy link
Contributor

gingerbeardman commented Apr 4, 2019

Proposal

Show extracted files in Finder should only do so if Finder isn't already showing them somewhere

Reproduce

  1. Open a Finder window showing an expanded folder structure (where you are in one folder and you click the arrow on a sub folder to see its contents)

https://www.macobserver.com/imgs/tips/2012127_Collapsed.jpg

  1. Have a zip in the expanded folder and extract it.

  2. Upon completion a new Finder window will open showing the folder that contains the zip. (The folder that was expanded earlier)

Ideas

Keka could check paths of open Finder windows synchronously with extraction, so that (in most cases) there is no delay after extraction.

@aonez

This comment has been minimized.

Copy link
Owner

aonez commented Apr 4, 2019

@gingerbeardman I'm sure this won't be possible, at least with sandbox, not using some AppleScript or similar. Maybe it will be better to ask Apple to enhance the behaviour of this methods 1 2, that are responsible of this action:

 - (BOOL)selectFile:(NSString *)fullPath inFileViewerRootedAtPath:(NSString *)rootFullPath;
- (void)activateFileViewerSelectingURLs:(NSArray<NSURL *> *)fileURLs;

Anyway I suppose that the performance impact of searching trough an indeterminate number of expanded folders instead of just looking for the root folder (current behaviour) of every Finder window sadly makes this one a no-go.

@aonez aonez self-assigned this Apr 4, 2019

@aonez aonez added the wont fix label Apr 4, 2019

@aonez aonez added this to the Random bag milestone Apr 4, 2019

@gingerbeardman

This comment has been minimized.

Copy link
Contributor Author

gingerbeardman commented Apr 4, 2019

Yes my thoughts were as much, but I thought I'd suggest it in case anything changes in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.