Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome] applied crashpad patch from sifive #14

Conversation

unicornx
Copy link

@unicornx unicornx commented Mar 1, 2023

sifive chrome patches repo:
https://github.com/starfive-tech/riscv-nwjs-patch

cd
patch -d . -f -p1 --no-backup-if-mismatch
-i
<PATH_TO>/0043-third_party-crashpad-port-for-RISC-V.patch

Test: autoninja -v -C out/riscv64 third_party/crashpad/crashpad/client:client

TBD: just one failure on compiling third_party/crashpad/crashpad/client/crashpad_info_note.S /tmp/crashpad_info_note-6e68bc.s:22:9: error: Unsupported relocation type
.quad _ZN8crashpad15g_crashpad_infoE - desc

sifive chrome patches repo:
https://github.com/starfive-tech/riscv-nwjs-patch

cd <SRC>
patch -d . -f -p1 --no-backup-if-mismatch \
-i
<PATH_TO>/0043-third_party-crashpad-port-for-RISC-V.patch

Test: autoninja -v -C out/riscv64 third_party/crashpad/crashpad/client:client

TBD: just one failure on compiling third_party/crashpad/crashpad/client/crashpad_info_note.S
/tmp/crashpad_info_note-6e68bc.s:22:9: error: Unsupported relocation
type
  .quad _ZN8crashpad15g_crashpad_infoE - desc

Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
Signed-off-by: McKnight22 <tao.wang.2261@gmail.com>
@unicornx unicornx merged commit b564e3c into aosp-riscv:riscv64_109.0.5414.87_dev Mar 1, 2023
@unicornx unicornx deleted the dev-chrome-build-crashpad-pr branch March 1, 2023 02:28
@unicornx unicornx changed the title applied crashpad patch from sifive [chrome] applied crashpad patch from sifive Mar 3, 2023
@unicornx unicornx self-assigned this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant