Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic ST support #192

Merged
merged 5 commits into from
May 4, 2023
Merged

basic ST support #192

merged 5 commits into from
May 4, 2023

Conversation

ericmorelle
Copy link
Contributor

@ericmorelle ericmorelle commented May 2, 2023

I added some basic support for the ST (after checking out the first attempt by @r3w0p) .
Also I have seen that someone requested support for the ST-UV, but I only have a ST-VIS, so not shure if it works for both.

I also had a try on inspecting the USB communication with wireshark and was able to figure out the nonlinearity coefficients.
Maybe with some help I can do more features. If needed I could provide what i get out of wireshark.

@ap--
Copy link
Owner

ap-- commented May 2, 2023

Awesome ❤️
Thank you so much for your contribution!

Please fix the linting errors and then I'll merge this right away!

pip install pre-commit
pre-commit install
pre-commit run --all
# and then fix / stage and commit the changes

Cheers,
Andreas 😃

@ap--
Copy link
Owner

ap-- commented May 2, 2023

Also, can you confirm that the pytest test suite runs without errors, when the ST spectrometer is connected?

@ericmorelle
Copy link
Contributor Author

ericmorelle commented May 3, 2023

Thank for the quick reply. I'm happy that I can contribute something.
The linting errors should be fixed now.
The pytest test suite runs without failures but with two skips:

  • tests/test_spectrometers.py::TestHardware::test_crash_may_not_influence_following_tests[ST:ST00610-backend(any)] SKIPPED (FIXME: TEST BREAKS OTHER TESTS ON WINDOWS)
  • tests/test_spectrometers.py::TestHardware::test_correct_dark_pixels[ST:ST00610-backend(any)] SKIPPED (does not support dark counts)

first is obviously because i'm on windows at the moment, I tried it on linux a few days ago and as far as I remember it passed there.

second claims that dark counts are not supported. As far as I know it is supported in some way, but for now I couldn't figure it out or identify the dark_pixel_indices

@ericmorelle ericmorelle marked this pull request as ready for review May 3, 2023 07:31
@ap-- ap-- merged commit 2fcd949 into ap--:main May 4, 2023
@ap--
Copy link
Owner

ap-- commented May 4, 2023

second claims that dark counts are not supported. As far as I know it is supported in some way, but for now I couldn't figure it out or identify the dark_pixel_indices

The way to do this, would be to compare readings of the spectrometer when fully illuminated with a broad spectrum light source and when light is fully blocked. The dark pixels should not change their reading when illuminated

@ap-- ap-- mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants