use <abuf> to identify buffer during events #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix ap#39 - `lclose` can sometimes cause the tabline to disappear even when there are multiple buffers remaining. Essentially the problem is buftabline always assumes the buffer being deleted is the current buffer, which is generally true, but not always true. `bufnr('%')` gives us the number of the _current_ buffer which is not necessarily the buffer that is being added or deleted. `expand(<abuf>)` gives us the number of buffer on which the event is operating, but as a string - so we need to convert it to a number with `str2nr`. We can then determine if the actual buffer being deleted is a user buffer or not.
|
Yeah I don’t want the debris in there and I want the commit message a little less verbose, plus the comment needs tweaking now. But it’s quicker if I just amend the commit myself. Coming up. |
|
Applied as e662ccd. Thank you for the patch. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #39 -
lclosecan sometimes cause the tabline todisappear even when there are multiple buffers remaining. Essentially
the problem is buftabline always assumes the buffer being deleted is the
current buffer, which is generally true, but not always true.
bufnr('%')gives us the number of the current buffer which is notnecessarily the buffer that is being added or deleted.
expand('<abuf>')gives us the number of buffer on which the event is operating, but as a
string - so we need to convert it to a number with
str2nr. We can thendetermine if the actual buffer being deleted is a user buffer or not.
I unintentionally committed some changes deleting some trailing
whitespace - let me know if you want me to revert those lines.