-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Reference: Add support for nested types #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include nested types in types loaded from assemblies
Add support for nested types to TypeId and its derived types. Adjust ToTypeId() extension methods to properly handle nested types
Place documentation for nested types into subdirectories of the documentation of the declaring type.
Add examples of nested classes to demo project
Ignore non-public nested types
…nFormatter Improve generated C# definition of flags enum values. When the enum contains an "All" element (like e.g. AttributeTargets) and the value matches, display just the exact match instead of a or expression of all values. When displaying individual flag values, exclude enum values unless they are an exact match (e.g. do not always display 'AttributeTargets.All')
ap0llo
force-pushed
the
features/apireference/nested-types-support
branch
from
December 15, 2019 19:48
b35d4dc
to
96e8ba8
Compare
Add support for nested types to CSharpDefinitionFormatter
Show declaring type on documentation pages for nested types.
Add support for nested types to MemberIdParser. Currently, MemberIdParser will only return the correct id for nested types if the nested type is nested within a generic type. Otherwise the id of a nested type and a top-level type have the same format.
Add support for nested types to MemberIdParser. For ids to be parsed correctly, a list of non-nested types needs to be specified.
Include list of nested types in type documentation
Show full name (including name of declaring type) in C# definition of nested types
Rewrite code that requires C# 8.0
ap0llo
changed the title
WIP: API Reference: Add support for nested types
API Reference: Add support for nested types
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generation documentation for nested types
TypeId
to accommodate for nested typesCSharpDefinitionFormatter
to render full name including surrounding typesShould nested types show up in the type list or just in the docs page of the declaring type?