Configurable Water Protection #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisby-folk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this one more time!
This PR adds a new block to
origins_server.jsonthat allows individual toggling of water protection appearing in the enchanting table, on treasure books, and on treasure gear.By default, water protection only appears on treasure books - this prevents origins from changing game balance even when human is selected (by reducing the odds to get useful enchantments at the table and on loot gear)
It also adds an option to disable the registration of the water protection enchantment entirely - this is a utility option for modpackers that don't use the
water_vulnerabilitypower at all, intended to allow them to ensure that water protection is completely unobtainable - and doesn't appear in recipe viewers or the creative screen.If toggled by an unaware user, this option will naturally prevent them from joining origins servers due to the registry mismatch, and could potentially cause a crash via an origins addon (though a nullable annotation was added to prevent this into the future) - however, I think the tradeoffs are worth it in this case.