This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(scatter): fix legend and labels #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/scatter-category
branch
from
44fad91
to
12d0b65
Compare
kgabryje
reviewed
Aug 19, 2021
packages/superset-ui-legacy-preset-chart-deckgl/src/CategoricalDeckGLContainer.jsx
Show resolved
Hide resolved
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR fixes the following problems in the Scatter plugin:
undefined. This now shows the verbose name if defined (e.g.COUNT(*)for the saved metriccountin the example dataset)Fixes apache/superset#15738
AFTER
The legend works properly, along with the tooltip for metric name:
Point size control is now on a row of it's own:
Arc is also fixed:
BEFORE