This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
chore(chart): remove faux @superset-ui/core TS declaration #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 100% 99.79% -0.21%
==========================================
Files 76 76
Lines 958 959 +1
Branches 229 230 +1
==========================================
- Hits 958 957 -1
- Misses 0 1 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 76 76
Lines 958 965 +7
Branches 229 232 +3
=====================================
+ Hits 958 965 +7
Continue to review full report at Codecov.
|
kristw
reviewed
Mar 20, 2019
packages/superset-ui-chart/src/registries/ChartMetadataRegistrySingleton.ts
Outdated
Show resolved
Hide resolved
|
all right, made this compatible with the |
added 7 commits
March 22, 2019 10:43
williaster
force-pushed
the
chris--fix-core-TS-declaration-in-charts
branch
from
2d990e5
to
fc77263
Compare
delete-merged-branch
bot
deleted the
chris--fix-core-TS-declaration-in-charts
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This PR removes the faux
@superset-ui/coreTS declaration in@superset-ui/chart(introduced beforecorewas re-written in TS). All of the changes are to clean up resulting TS errors from that removal. Some notes on specifics that were done:types that were duplicated across files likeChartType,(Pre/Post)TransformProps, etc.. Turns out the duplication wasn't always entirely consistent though at surface level it might not be obvious.registrysValue | { default: Value }generally across loaders. This is now confined toChartPluginin order to simplify types elsewhere, while still supporting dynamic loading of ES modules:() => import('foo').default(EDIT: The following was refactored so as not to be a breaking change)
💔 Breaking ChangesRemoved support for{ default: Type }inRegistryloaders, which was previously allowed due to a Chart type usingmodule.exportsinstead ofexport defaulting. This simplifies typing when using these components which I think is a win 🏆. I think worst case if this is problematic in incubatorSupersetwe could update() => import('./module.xxx')calls to() => import('./module.xxx').defaultTODO
.defaultissue .. may not be a breaking change@kristw @conglei @xtinec