Improved logging of busiest tablets. #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alerman would you be able to take a look at this? |
ctubbsii
reviewed
Jul 25, 2019
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
|
The Travis build indicates some non-Java 7 stuff is being used for the 1.9 branch. These should be easier to catch after I implement #1236 |
ctubbsii
reviewed
Jul 25, 2019
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/BusiestTracker.java
Show resolved
Hide resolved
ctubbsii
approved these changes
Jul 25, 2019
Now the deltas of tablets ingest and query counts are used for computing the busiest N tablets. The previous code used the absolute counts. Restructured code that so that it is unit testable and found a few bugs while writing the unit test. Found the prioQ was not properly tracking the top N tablets.
keith-turner
force-pushed
the
accumulo-1187
branch
from
5aca8b8
to
8d6aae5
Compare
|
Made further improvements in #1296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacement of #1187 with the following improvements :