Add optional -t tablename to importdirectory shell command. #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the -t tablename is optional to preserve original behaviour. Without the option, the current table is used.
ctubbsii
reviewed
Jul 29, 2019
shell/src/main/java/org/apache/accumulo/shell/commands/ImportDirectoryCommand.java
Outdated
Show resolved
Hide resolved
|
I believe this update addresses the comments - still need to perform stand-alone testing before merge. |
ctubbsii
reviewed
Aug 1, 2019
|
I was wondering about this recently ( as a feature to want ) and was pointed to this -- seems to work well and looks good! |
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
* Remove unused variables in test * Verify mock objects in test
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
Switch ImportDirectoryCommandTest to use the newer (non-deprecated) bulk import API, and ensure the mock object is verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1294.
the -t tablename is optional to preserve original behavior. Without
the option, the current table is used.
Contains new unit tests, need to look into adding IT or at least running on cluster before merging