Fix #1314 fixes gc thread issue by creating one timed task instance #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
changed the title
ctubbsii
reviewed
Aug 9, 2019
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
Show resolved
Hide resolved
ctubbsii
previously approved these changes
Aug 9, 2019
keith-turner
reviewed
Aug 9, 2019
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
Show resolved
Hide resolved
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java
Show resolved
Hide resolved
ctubbsii
reviewed
Aug 11, 2019
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java
Outdated
Show resolved
Hide resolved
server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java
Show resolved
Hide resolved
ctubbsii
approved these changes
Aug 13, 2019
drewfarris
approved these changes
Aug 13, 2019
ctubbsii
approved these changes
Aug 13, 2019
ctubbsii
approved these changes
Aug 13, 2019
keith-turner
approved these changes
Aug 14, 2019
ctubbsii
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix moved the creation of the live tserver set to the simple garbage collector, outside of the run loop and passes it to the wal collector.
modified log message by putting guard to only print on changes and to include number of tservers.