Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-3616 Fix netty epoll not available #3887

Closed
wants to merge 1 commit into from

Conversation

brusdev
Copy link
Member

@brusdev brusdev commented Dec 20, 2021

No description provided.

Copy link
Contributor

@franz1981 franz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clebertsuconic
Copy link
Contributor

@brusdev can you add a smoke test to avoid this happening again please as part of this PR?

@brusdev brusdev marked this pull request as draft December 20, 2021 13:38
artemis-core-client/pom.xml Outdated Show resolved Hide resolved
artemis-distribution/pom.xml Outdated Show resolved Hide resolved
artemis-server/pom.xml Outdated Show resolved Hide resolved
@brusdev brusdev marked this pull request as ready for review January 5, 2022 08:55
@brusdev
Copy link
Member Author

brusdev commented Jan 5, 2022

Unnecessary transitive dependencies removed as suggested by @gemmellr
Logs for NIO switching added as suggested by @franz1981
NettyNative smoke test added as suggested by @clebertsuconic
Thanks a lot for your suggestions

@gemmellr
Copy link
Member

I rebased this and merged via commits cb96a89 and 0e2fbad but typod the reference in the merge commit so it hasnt closed.

Can you please close it @brusdev?

@brusdev
Copy link
Member Author

brusdev commented Jan 17, 2022

@gemmellr thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants