ARTEMIS-3940 Address.maxSizeMessage is ignored on FAIL and Blocking Paging Policy #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
commented
Aug 15, 2022
Comment on lines
334
to
342
| AddressSettings set = new AddressSettings(); | ||
| set.setAddressFullMessagePolicy(AddressFullMessagePolicy.FAIL); | ||
| if (global) { | ||
| config.setGlobalMaxMessages(10); | ||
| } | ||
|
|
||
| settings.put( "FAIL_MAX_MESSAGES_CORE", set); | ||
| settings.put( "FAIL_MAX_MESSAGES_OPENWIRE", set); | ||
| settings.put( "FAIL_MAX_MESSAGES_AMQP", set); |
There was a problem hiding this comment.
... I will remove these lines.. forgot those hanging.
|
The commit message says "ignorecase." It seems like this should just be "ignored." |
|
@jbertram ouch.. thanks.... I typed :set ignorecase in vim, and somehow my mind did that trick to me :) |
clebertsuconic
force-pushed
the
ARTEMIS-3928
branch
from
ac31219
to
084bbc5
Compare
clebertsuconic
changed the title
clebertsuconic
force-pushed
the
ARTEMIS-3928
branch
from
21203e9
to
7e5ea7f
Compare
clebertsuconic
force-pushed
the
ARTEMIS-3928
branch
from
7e5ea7f
to
3194241
Compare
clebertsuconic
force-pushed
the
ARTEMIS-3928
branch
from
3194241
to
5f0bc6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.