ARTEMIS-4548 refactor MQTT tests #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-4548
branch
2 times, most recently
from
db5ea3b
to
8738410
Compare
|
Not clear if you ran the full test suite on this already, but probably worth a rebase and re-run at this point either way. Havent looked at it yet but will try to get to it soon. |
Many MQTT tests are run twice - once using TCP and once using WebSockets. This is essentially a big waste of time since once the connection is established to the broker the tests are identical. The tests should be refactored to run just once and then there can be a small number of tests specifically for WebSockets. This should knock several minutes off the test-suite.
jbertram
force-pushed
the
ARTEMIS-4548
branch
from
8738410
to
77cf6ad
Compare
|
Rebased. Test-suite is good! |
|
Change seems to make sense as it reduces redundant test runs, something we made the mistake of doing in the 5.x code base was have all protocol tests run for every permutation of TCP, SSL, NIO, Auto, etc transports which explodes the test time. It is important to create tests that capture any cases where the protocol or transport do come into play though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many MQTT tests are run twice - once using TCP and once using WebSockets. This is essentially a big waste of time since once the connection is established to the broker the tests are identical. The tests should be refactored to run just once and then there can be a small number of tests specifically for WebSockets.
This should knock several minutes off the test-suite.