-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMQ-9207] Upgrade various dependencies #964
Conversation
Please ping me before such kind of updates, I already had all atomic dep updates ready. |
I agree for the PR, but the Jira should be atomic as it's better for release notes IMHO. I will rebase my changes (I have others on the way). |
com.thoughtworks.xstream:xstream .................... 1.4.19 -> 1.4.20 commons-daemon:commons-daemon ......................... 1.3.2 -> 1.3.3 org.apache.ant:ant ................................ 1.10.12 -> 1.10.13 org.apache.shiro:shiro-core ......................... 1.10.1 -> 1.11.0 org.apache.shiro:shiro-spring ....................... 1.10.1 -> 1.11.0 org.codehaus.jettison:jettison ........................ 1.5.2 -> 1.5.3 regexp:regexp ............................................. 1.3 -> 1.5 org.apache.httpcomponents:httpclient ................ 4.5.13 -> 4.5.14 org.apache.httpcomponents:httpcore .................. 4.4.15 -> 4.4.16 - regexp/regexp -> jakarta-regexp/jakarta/regexp
That sounds good, I'll go ahead and update JIRA for individual JIRAs for the release notes. Thx |
Right, for minor stuff there's no reason to have like 10 commits when they can be combined into one commit like this but the major stuff like Spring for sure should be by itself. For Jira I think we should be able to create one top level Jira issue for the minor dependency updates and then have subtasks for each individual update. Then the PR that does the multiple changes at once could just reference the main Jira but the release notes would still list all the individual dependencies because of the sub tasks (I think but need to test) |
@cshannon yeah it's what I meant. The most important for our users is to have details in the release notes. |
com.thoughtworks.xstream:xstream .................... 1.4.19 -> 1.4.20 commons-daemon:commons-daemon ......................... 1.3.2 -> 1.3.3 org.apache.ant:ant ................................ 1.10.12 -> 1.10.13 org.apache.shiro:shiro-core ......................... 1.10.1 -> 1.11.0 org.apache.shiro:shiro-spring ....................... 1.10.1 -> 1.11.0 org.codehaus.jettison:jettison ........................ 1.5.2 -> 1.5.3 regexp:regexp ............................................. 1.3 -> 1.5 org.apache.httpcomponents:httpclient ................ 4.5.13 -> 4.5.14 org.apache.httpcomponents:httpcore .................. 4.4.15 -> 4.4.16 - regexp/regexp -> jakarta-regexp/jakarta/regexp (cherry picked from commit 3445456)
com.thoughtworks.xstream:xstream .................... 1.4.19 -> 1.4.20 commons-daemon:commons-daemon ......................... 1.3.2 -> 1.3.3 org.apache.ant:ant ................................ 1.10.12 -> 1.10.13 org.apache.shiro:shiro-core ......................... 1.10.1 -> 1.11.0 org.apache.shiro:shiro-spring ....................... 1.10.1 -> 1.11.0 org.codehaus.jettison:jettison ........................ 1.5.2 -> 1.5.3 regexp:regexp ............................................. 1.3 -> 1.5 org.apache.httpcomponents:httpclient ................ 4.5.13 -> 4.5.14 org.apache.httpcomponents:httpcore .................. 4.4.15 -> 4.4.16 - regexp/regexp -> jakarta-regexp/jakarta/regexp (cherry picked from commit 3445456)
Dependency updates:
com.thoughtworks.xstream:xstream .................... 1.4.19 -> 1.4.20
commons-daemon:commons-daemon ......................... 1.3.2 -> 1.3.3
org.apache.ant:ant ................................ 1.10.12 -> 1.10.13
org.apache.shiro:shiro-core ......................... 1.10.1 -> 1.11.0
org.apache.shiro:shiro-spring ....................... 1.10.1 -> 1.11.0
org.codehaus.jettison:jettison ........................ 1.5.2 -> 1.5.3
regexp:regexp ............................................. 1.3 -> 1.5
org.apache.httpcomponents:httpclient ................ 4.5.13 -> 4.5.14
org.apache.httpcomponents:httpcore .................. 4.4.15 -> 4.4.16