Agtype hash cmp #1893
Merged
Agtype hash cmp #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian's s390x architecture, some regression tests were failing because the result set was reordered. Fix by attaching ORDER BY in problematic cases.
Output of the agtype_hash_cmp function varies depending on the machine endianness. Move tests to a separate file and supply little-endian and big-endian output expected files.
jrgemignani
approved these changes
May 23, 2024
MuhammadTahaNaveed
approved these changes
May 23, 2024
|
@df7cb Please also create PRs for the PG16, PG15, PG14, and PG13 branches. |
|
@df7cb Please make sure to fill out the description for them :)
|
|
The text is in the git log, stupid github. Done now. |
|
@df7cb Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move agtype_hash_cmp tests to separate file
Output of the agtype_hash_cmp function varies depending on the machine
endianness. Move tests to a separate file and supply little-endian and
big-endian output expected files.
As discussed in #1503.