Implementation of GCP Transport #6
Conversation
…into GCSTransport
…into GCSTransport
GCS transport implementation
There was a problem hiding this comment.
Thanks for the PR and it's really good to see that you have captured transport integration properly. I need you to cleanup the PR a little bit as there are some unrelated files and changes into the config files. As a major design change, I think that secret json should be serialized into the secret object itself rather than loading from a file path. Good job. Just few corrections needed
.../gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSMetadataCollector.java
Outdated
Show resolved
Hide resolved
.../gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSMetadataCollector.java
Outdated
Show resolved
Hide resolved
.../gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSMetadataCollector.java
Outdated
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSReceiver.java
Outdated
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
Outdated
Show resolved
Hide resolved
|
We have implemented the suggested changes. |
services/secret-service/stub/src/main/proto/SecretService.proto
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
Outdated
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSReceiver.java
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSReceiver.java
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
Outdated
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
Outdated
Show resolved
Hide resolved
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
Outdated
Show resolved
Hide resolved
|
|
||
| HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport(); | ||
| JsonFactory jsonFactory = new JacksonFactory(); | ||
| String jsonString = gcsSecret.getJsonCredentialsFilePath(); |
There was a problem hiding this comment.
Good. Please change the property name to jsonFileCredentialsFilePath => credentialJson and refer to my comments given to file based secret backend
|
We have implemented the requested changes. Please do check and let us know. 👍 |
...main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
Outdated
Show resolved
Hide resolved
|
@DImuthuUpe Okay we will add the license headers 👍 Sorry, but i am a bit unclear on what are the minor suggestions you are referring to? Is it about the indentation or the content type as null? |
It's the indentation issue. I saw that you have changed the content type to null |
|
We have changed the indentation issue and added the license headers. Can you please look into the changes once again? |
|
All look good to me. Great work. I'm going to merge this |
@DImuthuUpe @smarru
We have created the GCP Transport implementation along with a basic API Gateway implementation to initiate transfers and check the status of the transfers. You need to add the path of Google Cloud Project service account credential JSON into secrets.json for Secret Service.
Your feedback is most welcome.