Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable grid view components #27512

Closed
2 tasks done
NilsJPWerner opened this issue Nov 4, 2022 · 6 comments · Fixed by #27560
Closed
2 tasks done

Resizable grid view components #27512

NilsJPWerner opened this issue Nov 4, 2022 · 6 comments · Fixed by #27560
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests

Comments

@NilsJPWerner
Copy link

NilsJPWerner commented Nov 4, 2022

Description

1. Ability to change change the split ratio of the grid section and the task details section. - already done in #27273
resizable_horizontal

  1. Ability for the log window to be resized.
    resizable_vertical

  2. Would love if the choices stuck between reloads as well.

Use case/motivation

I love the new grid view and use it day to day to check logs quickly. It would be easier to do so without having to scroll within the text box if you could resize the grid view to accommodate a larger view of the logs.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@NilsJPWerner NilsJPWerner added the kind:feature Feature Requests label Nov 4, 2022
@potiuk
Copy link
Member

potiuk commented Nov 5, 2022

Already done in #27273 but I think they are not sticky between reloads @bbovenzi WDYT?

@NilsJPWerner
Copy link
Author

Ah I missed that pr. I think that covers 1, but not request 2 or 3.

@potiuk
Copy link
Member

potiuk commented Nov 6, 2022

Marked it as good first issue

@uranusjr uranusjr added the area:UI Related to UI/UX. For Frontend Developers. label Nov 7, 2022
@uranusjr
Copy link
Member

uranusjr commented Nov 7, 2022

cc @bbovenzi in case you are already working on this

@bbovenzi
Copy link
Contributor

bbovenzi commented Nov 7, 2022

Yep! I was already working to fix the logs too.

And I can play around with maintaining the sizing between reloads.

@NilsJPWerner
Copy link
Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants