Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with system test - tests/system/providers/microsoft/azure/example_azure_blob_to_gcs.py #31809

Closed
2 tasks done
Adaverse opened this issue Jun 8, 2023 · 2 comments
Closed
2 tasks done
Assignees

Comments

@Adaverse
Copy link
Contributor

Adaverse commented Jun 8, 2023

Apache Airflow version

2.6.1

What happened

I was going through tests/system/providers/microsoft/azure/example_azure_blob_to_gcs.py, and after grasping the motive behind the system test, one thing is that each of these tests should be self-sufficient dags and should act as a good example for that specific object (sensor, operator, etc...) under test. In the above case, the dag flow -

    (
        wait_for_blob
        >> wait_for_blob_async
        >> wait_for_blob_prefix
        >> wait_for_blob_prefix_async
        >> transfer_files_to_gcs
    )

Please correct me if I'm wrong, but isn't this test waiting for a blob to exist before testing the main operator (that it is supposed to test) i.e. AzureBlobStorageToGCSOperator. Hence waiting for some external service (or some dag or task) to create the blob to continue with the test. Or am I missing something here or is the part of the pre-configuration that is needed to be done for this - just not documented?

According to me, it should have been something like this -

        create_blob_azure
        >> transfer_files_to_gcs
        >> check_in_gcs    # for successful transfer

What you think should happen instead

No response

How to reproduce

.

Operating System

.

Versions of Apache Airflow Providers

.

Deployment

Other

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Adaverse Adaverse added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jun 8, 2023
@Adaverse
Copy link
Contributor Author

Adaverse commented Jun 8, 2023

cc- @phanikumv

@phanikumv phanikumv self-assigned this Jun 9, 2023
@phanikumv phanikumv added area:providers provider:microsoft-azure Azure-related issues and removed kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet area:core labels Jun 9, 2023
@phanikumv
Copy link
Contributor

I agree with you that this example DAG should just showcase how to move an existing blob to GCS. So please go ahead and create PR for this. I don't think you need to create issues for these things, unless it is a bug or a new feature :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants