-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webserver ingress annotations #12619
Conversation
@ecerulm Can you add tests to avoid regression? |
@mik-laj I've added two tests, I had to do other changes unrelated to the ingress annotations because the current template output did not validate :
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
The indentation under `web.annotations` was wrong (6 leading spaces on first line, 4 on the rest) leading to Error converting YAMl to JSON: yaml: line 32: did not find expected key when you run helm chart with value `ingres.web.annotations`
e4b5f45
to
5f90b2b
Compare
Since the chart hasn't yet been released upgrading the minimum kube version is no problem. |
The indentation under `web.annotations` was wrong (6 leading spaces on first line, 4 on the rest) leading to Error converting YAMl to JSON: yaml: line 32: did not find expected key when you run helm chart with value `ingres.web.annotations` (cherry picked from commit 07670ec)
The indentation under `web.annotations` was wrong (6 leading spaces on first line, 4 on the rest) leading to Error converting YAMl to JSON: yaml: line 32: did not find expected key when you run helm chart with value `ingres.web.annotations` Partial Commit Extracted From: https://github.com/apache/airflow
The indentation under web.annotation was wrong (6 leading spaces
on first line, 4 on the next) leading to
when more that 1 annotation was provided.
@potiuk
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.