-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure Flower's url_prefix #12630
Conversation
What's the progress for this pr? I also need |
There is already a config setting for this -- |
{{- if .Values.flower.url_prefix }} | ||
- name: FLOWER_URL_PREFIX | ||
value: {{.Values.flower.url_prefix }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.
Instead of adding a new setting for this, we should
{{- if .Values.flower.url_prefix }} | |
- name: FLOWER_URL_PREFIX | |
value: {{.Values.flower.url_prefix }} | |
{{- end }} | |
{{- include "custom_airflow_environment" . | indent 10 }} |
Then the existing environment variable would work. Right now without any changes this can be set in the airflow.cfg config map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've dropped all other changes and just added this include.
@ashb, I don't understand. I can't find any The ideal would be to generate the |
Ok, nevermind. Yes there is flower_url_prefix that can be set with |
779eac9
to
c27dd36
Compare
(cherry picked from commit c2ead47)
When deploying with the Helm chart using an ingress for flower that has a path (
ingress.flower.path
) flower is currently unusable.Flower by default assumes that it will be serving url starting on
/
and it must be told via url_prefix if it's actual url is not based directly on/
.Currently there is no way (that I know of) to pass
url_prefix
to the Flower deployment/pod.This PR introduces a new helm chart value
flower.url_prefix
to allow for that.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.