Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to create users in LDAP mode #22619

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Add possibility to create users in LDAP mode #22619

merged 2 commits into from
Apr 1, 2022

Conversation

dx034
Copy link
Contributor

@dx034 dx034 commented Mar 30, 2022

Closes #18545 , code changes are identical to the ones made for remote user mode in #19963.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 30, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 30, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 4e4c057 into apache:main Apr 1, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 1, 2022

Awesome work, congrats on your first merged pull request!

@dx034
Copy link
Contributor Author

dx034 commented Apr 5, 2022

@potiuk Thanks for merging the changes. Do you think this could still be considered for 2.2.6, given that it's a minor fix?

@ashb
Copy link
Member

ashb commented Apr 5, 2022

I'm afraid not @dx034 -- 2.2.x is only bug fixes, and this is firmly in New Feature territory. The good news is that 2.3.0 "days" away from starting beta/RC so should be out soon.

(And we won't be releasing a 2.2.6 anyway)

@potiuk
Copy link
Member

potiuk commented Apr 5, 2022

Yep. 2.3.0 it is. With all the batteries included :)

@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add a new user when logged using LDAP auth
4 participants