Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reload pods when using the same DAG tag #24576

Merged
merged 8 commits into from
Jul 12, 2022
Merged

Conversation

sybernatus
Copy link
Contributor

Using the same tag for airflow dags cannot work as kubernetes will not refresh pods (scheduler, workers, webservers) if they are not updated.
Then you need to trigger the reloading of those pods manually.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

Using the same tag for airflow dags cannot work as kubernetes will not refresh pods (scheduler, workers, webservers) if they are not updated.
Then you need to trigger the reloading of those pods manually.
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@sybernatus
Copy link
Contributor Author

Related issue: #23895

Update documentation to update pods using same DAG tag using random airflow annotation instead of manual deleting pods
docs/helm-chart/manage-dags-files.rst Outdated Show resolved Hide resolved
indent warning message so it goes in the warning block
remove the italic style
@uranusjr uranusjr dismissed their stale review July 4, 2022 06:14

Resolved

@potiuk potiuk requested a review from jedcunningham July 4, 2022 07:12
@potiuk
Copy link
Member

potiuk commented Jul 4, 2022

Nice

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

@jedcunningham ?

@potiuk potiuk merged commit 50531f3 into apache:main Jul 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.7.0 milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants