Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reload pods when using the same DAG tag #24576

Merged
merged 8 commits into from
Jul 12, 2022
Merged

doc: reload pods when using the same DAG tag #24576

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec2c48b
doc: reload pods when using the same DAG tag
sybernatus Jun 21, 2022
fa13bc3
Add warning for constant tag usage
sybernatus Jun 21, 2022
67f19c6
doc: fix rst warning syntax
sybernatus Jul 3, 2022
4ff1eed
doc: reload pods by using random annotation
sybernatus Jul 3, 2022
1c96f9e
doc: Indent warning message
sybernatus Jul 4, 2022
746ac1f
Merge branch 'main' into patch-1
sybernatus Jul 8, 2022
7e4d213
Update docs/helm-chart/manage-dags-files.rst
eladkal Jul 12, 2022
c86a707
Update docs/helm-chart/manage-dags-files.rst
eladkal Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion docs/helm-chart/manage-dags-files.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,19 @@ Finally, update the Airflow pods with that image:

If you are deploying an image with a constant tag, you need to make sure that the image is pulled every time.

.. warning::

Using constant tag should be used only for testing/development purpose. It is a bad practice to use the same tag as you'll lose the history of your code.

.. code-block:: bash

helm upgrade --install airflow apache-airflow/airflow \
--set images.airflow.repository=my-company/airflow \
--set images.airflow.tag=8a0da78 \
--set images.airflow.pullPolicy=Always
--set images.airflow.pullPolicy=Always \
--set airflowPodAnnotations.random=r$(uuidgen)

sybernatus marked this conversation as resolved.
Show resolved Hide resolved
eladkal marked this conversation as resolved.
Show resolved Hide resolved
The randomly generated pod annotation will ensure that pods are refreshed on helm upgrade.

If you are deploying an image from a private repository, you need to create a secret, e.g. ``gitlab-registry-credentials`` (refer `Pull an Image from a Private Registry <https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/>`_ for details), and specify it using ``--set registry.secretName``:

Expand Down