-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto tail file logs in Web UI #26169
Auto tail file logs in Web UI #26169
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
8bbfbcb
to
7633a6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire log structure needs some love and refactoring work.
…le with tail feature of file task handler, +remove 1 mypy glitch in wasb/signature
… metadata is handeled correctly in recursion
… glitch in download of log when task is running
… test for task state
… test for task state
6fe8ff8
to
afc8225
Compare
…il-file-logs-in-ui
Hi @uranusjr Thanks for the review, the PR is "stale" now since a few days. Are further reviews needed? If yes, please let me know whom to get in touch with. Otherwise, if all is okay, who would be eligible to merge? (preventing further conflicts) |
…il-file-logs-in-ui
This PR implements a log tail feature on file_task_handler
As described in #15783 it would be a great feature to have log tail available in Airflow UI so that if you watch something running you don't need to hit the F5 key constantly to follow the running task.
Actually I saw the same demand and with this PR want to contribute this feature upstream.
I wanted to implement this from scratch when I realized that an auto-tail is already implemented in the UI, just the back-end needs to feed data in a way that tail is active. So this PR is a minimal-invasive implementation on the
file_task_handler.py
alongside with small adjustments to inheriting provider implementation.closes: #15783
related: #15783
How to test:
Example DAG I used for testing, running 200 seconds and adding log lines every second: