-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync v2-9-stable with v2-9-test to release python client v2.9.0 #39061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will need one or two cherry-picks more from main to fix but LGTM in general.
dirrao
approved these changes
Apr 16, 2024
When PROD image packages are installed in in CI, the local sources should not be present in the image, also constraints from sources shoudl replace the one downloaded from main. (cherry picked from commit 246f697)
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests. (cherry picked from commit 3f4872b)
(cherry picked from commit d212b11)
…rs (#38825) Occasionally `docker syetem prune` fails on Public docker runners with file resize error: truncate /var/lib/docker/buildkit/containerdmeta.db: read-only file system This happens after docker has been already cleaned and should have no side efects if the metadata db could not be truncated. Ignoring error in this case should allow the job to continue. (cherry picked from commit f50cc61)
(cherry picked from commit 3af00fa)
(cherry picked from commit 6995eaf)
(cherry picked from commit 1d34045)
(cherry picked from commit 3025096)
The xmlsec used by Amazon provider for authentication has compatiblity issue with libxmlsec 1.2.* that is used by default in debian bookworm. We should investigate if/howe we can upgrade our images to support it, in the meantime we limitt python bindings to < 1.3.13. See #39103 (cherry picked from commit cd88887)
(cherry picked from commit 4341892)
There is a simple workaround implemented several years ago for Google provider `project_id` default value being PROVIDE_PROJECT_ID that satisfy mypy checks for project_id being set. They way how `fallback_to_default_project_id` works is that across all the providers the project_id is actually set, even if technically it's default value is set to None. This is similar typing workaround as we use for NEW_SESSION in the core of Airflow. The workaround has not been applied consistently across all the google provider code and occasionally it causes MyPy complaining when newer version of a google library introduces more strict type checking and expects the provider_id to be set. This PR applies the workaround across all the Google provider code. This is - generally speaking a no-op operation. Nothing changes, except MyPy being aware that the project_id is actually going to be set even if it is technically set to None. (cherry picked from commit 90acbfb)
eladkal
approved these changes
Apr 19, 2024
jedcunningham
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:API
Airflow's REST/HTTP API
area:dev-tools
area:production-image
Production image improvements and fixes
kind:documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time for python client
2.9.0rc1
!