Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5836] Pin azure-storage-blob version to <12 #6486

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Nov 1, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5836
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj changed the title [AIRFLOW-YYY] Pip azure-storage-blob version to <12 [AIRFLOW-YYY][WIP] Pip azure-storage-blob version to <12 Nov 1, 2019
setup.py Show resolved Hide resolved
@mik-laj mik-laj changed the title [AIRFLOW-YYY][WIP] Pip azure-storage-blob version to <12 [AIRFLOW-YYY][WIP] Pin azure-storage-blob version to <12 Nov 1, 2019
@mik-laj mik-laj changed the title [AIRFLOW-YYY][WIP] Pin azure-storage-blob version to <12 [AIRFLOW-5836] Pin azure-storage-blob version to <12 Nov 1, 2019
@feluelle
Copy link
Member

feluelle commented Nov 1, 2019

I restarted the failed check.

It was failing due to:

  Traceback (most recent call last):

    /usr/local/lib/python3.5/unittest/mock.py line 1159 in patched

      return func(*args, **keywargs)

    tests/jobs/test_local_task_job.py line 161 in test_heartbeat_failed_fast

      self.assertGreaterEqual((time2 - time1).total_seconds(), job.heartrate)

   AssertionError: 1.998126 not greater than or equal to 2

(another flaky test :/)

@codecov-io
Copy link

Codecov Report

Merging #6486 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6486      +/-   ##
==========================================
- Coverage   83.96%   83.65%   -0.32%     
==========================================
  Files         635      635              
  Lines       36657    36657              
==========================================
- Hits        30780    30666     -114     
- Misses       5877     5991     +114
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/models/taskinstance.py 93.28% <0%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdb329...4f329a8. Read the comment docs.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a temporarily solution there is the Jira Ticket to remove this extra dependency once the issue is solved. See https://issues.apache.org/jira/browse/AIRFLOW-5837 for more information.

@mik-laj mik-laj merged commit 8f7663b into apache:master Nov 1, 2019
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants