Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2369]Optimize project module structure #2374

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

Close #2369 .

Brief change log

  • Restructure project modules.
  • Change docs due to the module change.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:build module:ams-dashboard Ams dashboard module labels Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe5ba0e) 52.98% compared to head (9e1317d) 52.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2374      +/-   ##
============================================
- Coverage     52.98%   52.95%   -0.04%     
+ Complexity     4302     4299       -3     
============================================
  Files           516      516              
  Lines         29716    29716              
  Branches       2896     2896              
============================================
- Hits          15746    15737       -9     
- Misses        12692    12702      +10     
+ Partials       1278     1277       -1     
Flag Coverage Δ
core 53.34% <ø> (-0.01%) ⬇️
trino 50.89% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoujinsong
Copy link
Contributor Author

The rename operation will not conflict with other line changes, so it is safe to merge this PR even through the File Changes is quite large.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why haven't the parts related to core and mixed-format been moved to the mixed module?
  2. Regarding the unified catalog section, is a separate module needed?

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR #2269 is introducing the UnifiedCatalog implementation on the Spark engine side, which will create massive conflicts with this PR.
I suggest merging the engine-side implementation first before proceeding with this matter.

@zhoujinsong
Copy link
Contributor Author

zhoujinsong commented Nov 30, 2023

  1. Why haven't the parts related to core and mixed-format been moved to the mixed module?

These tasks are indeed necessary, however, this PR will not introduce new modules or move classes to other modules. Maybe we can complete these tasks with other PRs.

  1. Regarding the unified catalog section, is a separate module needed?

I think so.

@zhoujinsong
Copy link
Contributor Author

The PR #2269 is introducing the UnifiedCatalog implementation on the Spark engine side, which will create massive conflicts with this PR. I suggest merging the engine-side implementation first before proceeding with this matter.

As I mentioned above, the rename operation will not conflict with other line changes. However, considering that #2269 may introduce new classes, these new classes might create conflicts. Nevertheless, such conflicts should be relatively easy to resolve.

I am uncertain about when #2269 can be merged, so I suggest that this PR not wait for the merge of #2269.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can extract UnifiedCatalog and rename package in another PR

@zhoujinsong zhoujinsong merged commit ca2061e into apache:master Nov 30, 2023
6 of 7 checks passed
@zhoujinsong zhoujinsong deleted the optimize-module-structure branch November 30, 2023 07:41
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* change module structure

* add ams/dist

* rollback docs format change

* Rollback README format change

* Rollback README format change

* Rollback docs format change

* Change Github CI configuration & docker build scripts

* Change Github CI configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module type:build type:docs Improvements or additions to documentation type:infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Optimize the project's module structure
2 participants