-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2369]Optimize project module structure #2374
[AMORO-2369]Optimize project module structure #2374
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2374 +/- ##
============================================
- Coverage 52.98% 52.95% -0.04%
+ Complexity 4302 4299 -3
============================================
Files 516 516
Lines 29716 29716
Branches 2896 2896
============================================
- Hits 15746 15737 -9
- Misses 12692 12702 +10
+ Partials 1278 1277 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The rename operation will not conflict with other line changes, so it is safe to merge this PR even through the File Changes is quite large. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why haven't the parts related to core and mixed-format been moved to the mixed module?
- Regarding the unified catalog section, is a separate module needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR #2269 is introducing the UnifiedCatalog implementation on the Spark engine side, which will create massive conflicts with this PR.
I suggest merging the engine-side implementation first before proceeding with this matter.
These tasks are indeed necessary, however, this PR will not introduce new modules or move classes to other modules. Maybe we can complete these tasks with other PRs.
I think so. |
As I mentioned above, the rename operation will not conflict with other line changes. However, considering that #2269 may introduce new classes, these new classes might create conflicts. Nevertheless, such conflicts should be relatively easy to resolve. I am uncertain about when #2269 can be merged, so I suggest that this PR not wait for the merge of #2269. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can extract UnifiedCatalog and rename package in another PR
* change module structure * add ams/dist * rollback docs format change * Rollback README format change * Rollback README format change * Rollback docs format change * Change Github CI configuration & docker build scripts * Change Github CI configurations
Why are the changes needed?
Close #2369 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation