-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hot-fix] Fix the NullPointerException
when modifying the self-optimizing.enabled
#2388
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
============================================
- Coverage 52.96% 52.96% -0.01%
+ Complexity 4303 4299 -4
============================================
Files 516 516
Lines 29716 29717 +1
Branches 2896 2897 +1
============================================
Hits 15739 15739
- Misses 12699 12701 +2
+ Partials 1278 1277 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…mizing.enabled` (apache#2388) fix NPE
Why are the changes needed?
When I changed the
self-optimizing.enabled
fromtrue
tofalse
, I got this error message if there is no running optimizing process.Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation