Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2864] Filter the null field when estimate size of records #2865

Merged
merged 2 commits into from
May 27, 2024
Merged

[AMORO-2864] Filter the null field when estimate size of records #2865

merged 2 commits into from
May 27, 2024

Conversation

XBaith
Copy link
Contributor

@XBaith XBaith commented May 26, 2024

Why are the changes needed?

Close #2864.

Brief change log

  • Fix NPE

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:core Core module label May 26, 2024
zhoujinsong
zhoujinsong approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the work! @XBaith

@zhoujinsong zhoujinsong merged commit a71710f into apache:master May 27, 2024
4 checks passed
@XBaith XBaith deleted the fix-spm-npe branch May 27, 2024 03:03
XBaith added a commit to XBaith/amoro that referenced this pull request Jul 17, 2024
@XBaith
[AMORO-2864] Filter the null field when estimate size of records (apa…
9849047 
…che#2865)

* Throw NPE if the number of last fields is less than the current number of fields

* checkstyle

(cherry picked from commit a71710f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:core Core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Throw NPE if the field is null when estimate the size of record
2 participants
@XBaith @zhoujinsong