Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2852]: fix eslint error & eslint config #2930

Closed
wants to merge 0 commits into from
Closed

[AMORO-2852]: fix eslint error & eslint config #2930

wants to merge 0 commits into from

Conversation

zhangmo8
Copy link
Member

@zhangmo8 zhangmo8 commented Jun 17, 2024 •
edited
Loading

Why are the changes needed?

fix eslint error & eslint config

Close #2852 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zhoujinsong
Copy link
Contributor

@minteliuwm Can you help to review?

@zhangmo8 zhangmo8 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module type:build type:infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Improve eslint rules and fix
2 participants
@zhangmo8 @zhoujinsong