[ARCTIC-486][FLINK]: Fix 'Watermark may loss if split read too fast' #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstraw
added
type:bug
added 2 commits
October 28, 2022 16:46
YesOrNo828
reviewed
Oct 28, 2022
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/util/FlinkClassUtil.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/test/java/com/netease/arctic/flink/table/TestUnkeyedOverwrite.java
Outdated
Show resolved
Hide resolved
wangtaohz
pushed a commit
to wangtaohz/amoro
that referenced
this pull request
Nov 7, 2022
…pache#523) * fix no watermark * fix classloader leaked check * resolve comment Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…523) * fix no watermark * fix classloader leaked check * resolve comment Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #486
Why are the changes needed?
If there is an eventTime field defined in arctic table by 'create table t (wm as cast(op_time as timestamp(3)), watermark for wm as wm) like XXX' , watermark may not emitted.
Fix this issue.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation