Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-486][FLINK]: Fix 'Watermark may loss if split read too fast' #538

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

zstraw
Copy link
Contributor

@zstraw zstraw commented Oct 28, 2022

FIX #486 to 0.3.x

Why are the changes needed?

If there is an eventTime field defined in arctic table by 'create table t (wm as cast(op_time as timestamp(3)), watermark for wm as wm) like XXX' , watermark may not emitted.

Fix this issue.

Brief change log

  • The flink 1.12 and 1.14, 1.15 versions are affected.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zstraw zstraw added type:bug Something isn't working module:mixed-flink Flink moduel for Mixed Format labels Oct 28, 2022
@zstraw zstraw added this to the Release 0.3.2 milestone Oct 28, 2022
@YesOrNo828 YesOrNo828 changed the base branch from master to 0.3.x October 28, 2022 09:07
Copy link
Contributor

@YesOrNo828 YesOrNo828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YesOrNo828 YesOrNo828 merged commit a8f5391 into apache:0.3.x Oct 28, 2022
@zstraw zstraw deleted the fix-wm-0.3 branch November 8, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Flink]: Watermark may loss if split read too fast.
2 participants