Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARCTIC-397][Core]Uprade iceberg version to 0.13.2 #569

Merged
merged 10 commits into from
Nov 8, 2022
Merged

[ARCTIC-397][Core]Uprade iceberg version to 0.13.2 #569

merged 10 commits into from
Nov 8, 2022

Conversation

zhoujinsong
Copy link
Contributor

@zhoujinsong zhoujinsong commented Nov 8, 2022 •
edited
Loading

Why are the changes needed?

Resolve #397. Uprade iceberg version to 0.13.2

Brief change log

  • Uprade iceberg version to 0.13.2
  • Change some dependencies

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zhoujinsong zhoujinsong added the module:core Core module label Nov 8, 2022
zstraw
zstraw reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@zstraw zstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Nullable->NonNull should be fix

.../src/main/java/com/netease/arctic/flink/read/hybrid/enumerator/AbstractArcticEnumerator.java Outdated Show resolved Hide resolved
zstraw
zstraw approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@zstraw zstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baiyangtx
baiyangtx approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark part is ok

@zhoujinsong zhoujinsong merged commit 943665a into apache:master Nov 8, 2022
@zhoujinsong zhoujinsong deleted the uprade-iceberg-version-0.13 branch November 8, 2022 11:48
zhoujinsong added a commit that referenced this pull request May 31, 2023
@zhoujinsong @zstraw
[ARCTIC-397][Core]Uprade iceberg version to 0.13.2 (#569)
7be17fe 
* uprade iceberg version to 0.13

* fix compile exception (#7)

Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>

* fix spark compile errors

* change dependencies

* fix flink moduel errors

* fix flink moduel unit test error

* fix comments

* fix annotation error in flink 1.12

* fix flink 1.14/1.15 unit test errors

* fix flink 1.14/1.15 unit test error

Co-authored-by: zstraw <zstraw@163.com>
Co-authored-by: zhuyuan03 <zhuyuan03@corp.netease.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baiyangtx baiyangtx baiyangtx approved these changes

@zstraw zstraw zstraw approved these changes

Assignees
No one assigned
Labels
module:core Core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Upgrade iceberg version to 0.13 or 0.14
3 participants
@zhoujinsong @baiyangtx @zstraw