Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARCTIC-877] Fix Orphan files clean delete files unexpected #878

Merged
merged 4 commits into from
Dec 8, 2022
Merged

[ARCTIC-877] Fix Orphan files clean delete files unexpected #878

merged 4 commits into from
Dec 8, 2022

Conversation

wangtaohz
Copy link
Contributor

Why are the changes needed?

fix #877

Brief change log

  • use URI of file path for valid files and actual files

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Dec 7, 2022
zhoujinsong
zhoujinsong approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 4b59f12 into apache:master Dec 8, 2022
@wangtaohz wangtaohz deleted the fix-877 branch December 8, 2022 01:57
wangtaohz added a commit to wangtaohz/amoro that referenced this pull request Dec 8, 2022
@wangtaohz
cherry-pick to 0.3.x [ARCTIC-877] Fix Orphan files clean delete files…
f163ead 
… unexpected (apache#878)

* fix apache#877 orphan files clean with file uri

* refactor orphan files clean metadata files

* fix checkStyle

* add unit test
@wangtaohz wangtaohz mentioned this pull request Dec 8, 2022
Merged
3 tasks
zhoujinsong pushed a commit that referenced this pull request Dec 8, 2022
@wangtaohz
[ARCTIC-877] Cherry-pick to 0.3.x, fix Orphan files clean delete file…
75ea452 
…s unexpected (#882)

cherry-pick to 0.3.x [ARCTIC-877] Fix Orphan files clean delete files unexpected (#878)

* fix #877 orphan files clean with file uri

* refactor orphan files clean metadata files

* fix checkStyle

* add unit test
This was referenced Apr 21, 2023
Open
Closed
zhoujinsong pushed a commit that referenced this pull request May 31, 2023
@wangtaohz
[ARCTIC-877] Fix Orphan files clean delete files unexpected (#878)
a6d66c4 
* fix #877 orphan files clean with file uri

* refactor orphan files clean metadata files

* fix checkStyle

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

@hzluting hzluting Awaiting requested review from hzluting

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Orphan files clean delete files unexpected
2 participants
@wangtaohz @zhoujinsong