Buffer for more Speed #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tg-freigmbh, very good catch. This indeed is an issue. I've added a trivial comment inline, other than that this looks good. |
jaikiran
reviewed
Jan 15, 2024
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java
Outdated
Show resolved
Hide resolved
|
I tried, but my ide realy doesnt like that :D maybe I can do it manually on github |
|
Thank you for the update, looks good to me. Since you are a first time contributor to Ant, we add your name to the contributors list we maintain in the repo. Is there a specific first name, last name you want us to add you as? |
|
Ah I already made an Contribution under a different account, I am Gösen ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that running tests using ant was much slower than running them from the IDE. The culprit was the legacy-xml reporter.
Using an unbuffered Output is very slow, even if you are using an .m2 disk..