This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
ANY23-304 Add extractor for OpenIE 1st pass #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansell
reviewed
Feb 16, 2017
| @@ -564,6 +569,4 @@ public static boolean isAbsoluteIRI(String href) { | |||
| } | |||
| } | |||
|
|
|||
| private RDFUtils() {} | |||
There was a problem hiding this comment.
Is this signalling an intention to change the scope of this class to include non-static methods?
There was a problem hiding this comment.
Possibly, I will see how the remainder of the implementation goes.
| for(Argument argument : listArg2s) { | ||
| sb.append(argument.text()).append("; "); | ||
| } | ||
| System.out.println(sb.toString()); |
There was a problem hiding this comment.
Presuming this is stub code right now that will eventually send results to the ExtractorResult.
Yes I think this is an excellent suggestion. I'm going to go ahead and refactor @ansell |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is a first pass at addressing https://issues.apache.org/jira/browse/ANY23-304. There is more work to be done on the new extractor. The new dependency which has been introduced has a significant impact on the size of Any23 as there are loads of new transitive dependencies. @Yongyao this is for context.