Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the manger API should not listen 8080, which is the port of data plane #901

Closed
moonming opened this issue Nov 28, 2020 · 7 comments · Fixed by #931
Closed

the manger API should not listen 8080, which is the port of data plane #901

moonming opened this issue Nov 28, 2020 · 7 comments · Fixed by #931
Assignees
Labels
bug Something isn't working
Milestone

Comments

@moonming
Copy link
Member

Bug report

https://github.com/apache/apisix-dashboard/blob/master/api/conf/conf.yaml#L21

Describe the bug

A clear and concise description of what the bug is.

How to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

Add screenshots to help explain your problem if applicable.

System information

  • OS: [e.g. macOS, Windows]
  • Browser (if applies) [e.g. Chrome, Safari, Edge]
  • Version: [e.g. 2.0-rc3]

Additional context

Add any other context about the problem here.

@moonming moonming added the bug Something isn't working label Nov 28, 2020
@moonming moonming added this to the 2.1.1 milestone Nov 28, 2020
@nic-chen
Copy link
Member

@moonming
OK. What is the recommended port? 9081 or 8081? Thanks.

@moonming
Copy link
Member Author

@gxthrj @membphis @spacewander @tokers what do you think about the port of CP?

@nic-chen
Copy link
Member

ping @gxthrj @membphis @spacewander @tokers
request help, thanks.

@tokers
Copy link
Contributor

tokers commented Nov 30, 2020

@moonming Since the admin api port in DP will be changed to 9180 in version 3.0, what about using 9180 also?

@membphis
Copy link
Member

membphis commented Nov 30, 2020

We used port 9180 as CP in APISIX now, I think this is not a good port.

I prefer 9000 now. Here are the reasons:

  1. The ports on the control plane and the data plane should be very different.
  2. The port of the control plane allows the use of HTTP protocol or HTTPS protocol. So this port number avoids any protocol-related identification (such as 80 or 443).

@gxthrj
Copy link
Contributor

gxthrj commented Nov 30, 2020

But I think 80/ 443 is more accepted by the public, and the manager-api will be completely independent in 3.0, the port of CP and DP do not affect each other, so we can treat CP as an independent project.
When deploying independently, IP or domain names can be distinguished, so you no longer need to care about ports.

@nic-chen
Copy link
Member

nic-chen commented Dec 1, 2020

Through a meeting, it was finally determined that the default port of dashboard manager api will change to 9000.

Participants:
@gxthrj @membphis @spacewander @tokers @moonming @ShiningRush @nic-chen

will send a mail to our maillist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants