Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade gjson to v1.6.7 #1366

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Conversation

ThanoshanMV
Copy link
Member

Please answer these questions before submitting a pull request

@codecov-io
Copy link

codecov-io commented Jan 24, 2021

Codecov Report

Merging #1366 (b08eab7) into master (446773f) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
+ Coverage   62.62%   62.83%   +0.21%     
==========================================
  Files          41       41              
  Lines        2360     2360              
==========================================
+ Hits         1478     1483       +5     
+ Misses        706      703       -3     
+ Partials      176      174       -2     
Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 49.49% <0.00%> (+1.01%) ⬆️
api/internal/core/store/store.go 88.60% <0.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446773f...b08eab7. Read the comment docs.

@ThanoshanMV ThanoshanMV changed the title Upgrade gjson to v1.6.7 build: upgrade gjson to v1.6.7 Jan 24, 2021
api/go.sum Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Member

cc @starsz to review

api/go.mod Outdated Show resolved Hide resolved
@membphis
Copy link
Member

and the front e2e failed: https://github.com/apache/apisix-dashboard/pull/1366/checks?check_run_id=1756969309#step:8:289

need @juzhiyuan confirm

@membphis
Copy link
Member

#1364

has been merged, @ThanoshanMV you can merge the master branch, fixed the e2e test cases of FE

@juzhiyuan
Copy link
Member

@ThanoshanMV Please sync with the latest codes from the master branch.

@ThanoshanMV
Copy link
Member Author

Okay, I'll do it @juzhiyuan

@membphis
Copy link
Member

membphis commented Jan 25, 2021

Okay, I'll do it @juzhiyuan

I just did it for you ^_^

@juzhiyuan juzhiyuan merged commit 8852e63 into apache:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a vulnerability in gjson v1.6.1,upgrade recommended
6 participants