Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update menu sidebar #2051

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: update menu sidebar #2051

merged 2 commits into from
Aug 10, 2021

Conversation

Ylikj
Copy link
Contributor

@Ylikj Ylikj commented Aug 9, 2021

Change the style of the last icon in the menu

Resolve the bug raised by #1335

Change the style of the last icon in the menu
@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 596941c

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/611155159a0bc30007971422

😎 Browse the preview: https://deploy-preview-2051--apisix-dashboard.netlify.app

@juzhiyuan juzhiyuan changed the title Update helpers.tsx fix: update helpers.tsx Aug 9, 2021
@juzhiyuan juzhiyuan changed the title fix: update helpers.tsx fix: update menu sidebar Aug 9, 2021
@juzhiyuan juzhiyuan requested a review from bzp2010 August 9, 2021 16:19
@codecov-commenter
Copy link

Codecov Report

Merging #2051 (596941c) into master (c3ea687) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
+ Coverage   65.88%   65.92%   +0.04%     
==========================================
  Files         121      121              
  Lines        3210     3211       +1     
  Branches      778      779       +1     
==========================================
+ Hits         2115     2117       +2     
+ Misses       1095     1094       -1     
Flag Coverage Δ
frontend-e2e-test 65.92% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 73.77% <ø> (+1.63%) ⬆️
web/src/app.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ea687...596941c. Read the comment docs.

@liuxiran liuxiran requested a review from LiteSun August 10, 2021 05:34
@liuxiran liuxiran merged commit b718ccd into apache:master Aug 10, 2021
@liuxiran
Copy link
Contributor

merged, thanks for your contribution @Ylikj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants