Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Type function to store interface #2160

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Oct 9, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Add a type function definition to the store interface to help judge which data entity a store manages.

A sub PR of #2099 #2144

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 self-assigned this Oct 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #2160 (9aa6118) into master (29e3084) will increase coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
+ Coverage   69.42%   69.46%   +0.03%     
==========================================
  Files         188      188              
  Lines        7147     7152       +5     
  Branches      823      823              
==========================================
+ Hits         4962     4968       +6     
+ Misses       1898     1897       -1     
  Partials      287      287              
Flag Coverage Δ
backend-e2e-test 46.88% <20.00%> (+0.43%) ⬆️
backend-e2e-test-ginkgo 48.80% <20.00%> (-0.31%) ⬇️
backend-unit-test 52.47% <0.00%> (-0.09%) ⬇️
frontend-e2e-test 68.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 88.54% <0.00%> (+0.64%) ⬆️
api/internal/core/store/store_mock.go 0.00% <0.00%> (ø)
api/internal/core/store/storehub.go 71.55% <100.00%> (+0.24%) ⬆️
api/internal/core/storage/etcd.go 51.18% <0.00%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e3084...9aa6118. Read the comment docs.

@bzp2010 bzp2010 requested a review from nic-chen October 11, 2021 02:37
@bzp2010 bzp2010 merged commit e432392 into apache:master Oct 11, 2021
@bzp2010 bzp2010 mentioned this pull request Oct 11, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants