Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add loading in route page #2287

Merged
merged 2 commits into from
Jan 25, 2022
Merged

chore: add loading in route page #2287

merged 2 commits into from
Jan 25, 2022

Conversation

CP3cham
Copy link
Contributor

@CP3cham CP3cham commented Jan 18, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Related issues

fix/resolve #2222

Checklist:

add loading status in route page when the Internet is slow

@juzhiyuan
Copy link
Member

cc @guoqqqi to have a review

@guoqqqi
Copy link
Member

guoqqqi commented Jan 19, 2022

please add the test

@CP3cham CP3cham changed the title fix loading in route page chore: add loading in route page Jan 19, 2022
@guoqqqi
Copy link
Member

guoqqqi commented Jan 21, 2022

@CP3cham ping
Did you have any problems?

@codecov-commenter
Copy link

Codecov Report

Merging #2287 (f245c1b) into master (e0d92c4) will decrease coverage by 1.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2287      +/-   ##
==========================================
- Coverage   69.91%   68.10%   -1.81%     
==========================================
  Files         184      127      -57     
  Lines        7279     3374    -3905     
  Branches      830      830              
==========================================
- Hits         5089     2298    -2791     
+ Misses       1896     1076     -820     
+ Partials      294        0     -294     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 68.10% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/List.tsx 82.84% <100.00%> (ø)
web/src/helpers.tsx 70.49% <0.00%> (-3.28%) ⬇️
api/internal/filter/logging.go
api/internal/handler/data_loader/route_import.go
api/internal/core/storage/etcd.go
api/internal/handler/stream_route/stream_route.go
api/cmd/version.go
api/internal/core/server/store.go
api/internal/core/server/http.go
api/internal/core/entity/entity.go
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d92c4...f245c1b. Read the comment docs.

Copy link
Contributor

@zaunist zaunist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution

@bzp2010 bzp2010 merged commit 4c8972e into apache:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Request Loading status
8 participants