Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable debug/pprof interface #2339

Merged
merged 1 commit into from
Feb 24, 2022
Merged

chore: disable debug/pprof interface #2339

merged 1 commit into from
Feb 24, 2022

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Feb 24, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

Disable pprof interface, just enable it locally when we need.

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix #2286

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #2339 (2ecada7) into master (fd44364) will increase coverage by 1.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
+ Coverage   68.17%   69.79%   +1.61%     
==========================================
  Files         127      184      +57     
  Lines        3375     7280    +3905     
  Branches      830      830              
==========================================
+ Hits         2301     5081    +2780     
- Misses       1074     1903     +829     
- Partials        0      296     +296     
Flag Coverage Δ
backend-e2e-test 37.10% <ø> (?)
backend-e2e-test-ginkgo 58.82% <ø> (?)
backend-unit-test 49.22% <ø> (?)
frontend-e2e-test 68.11% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/route.go 87.17% <ø> (ø)
web/src/pages/Upstream/List.tsx 90.00% <ø> (ø)
web/src/helpers.tsx 70.49% <0.00%> (-3.28%) ⬇️
api/internal/core/store/store.go 89.58% <0.00%> (ø)
api/internal/core/server/http.go 56.52% <0.00%> (ø)
api/internal/handler/label/label.go 86.20% <0.00%> (ø)
api/internal/utils/closer.go 66.66% <0.00%> (ø)
api/internal/handler/consumer/consumer.go 92.06% <0.00%> (ø)
api/internal/filter/authentication.go 77.77% <0.00%> (ø)
api/internal/handler/handler.go 79.31% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbecd55...2ecada7. Read the comment docs.

@zaunist
Copy link
Contributor Author

zaunist commented Feb 24, 2022

@bzp2010 @starsz @nic-chen
PTAL

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developers could comment or comment to debug

@juzhiyuan juzhiyuan merged commit 46c56f4 into apache:master Feb 24, 2022
@starsz
Copy link
Contributor

starsz commented Feb 24, 2022

Hi @zaunist @juzhiyuan.
I think we can create another host and port config to enable it in the config.

@zaunist zaunist deleted the chore/remove_pprof branch February 24, 2022 15:09
@apache apache deleted a comment from zaunist Feb 24, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Mar 13, 2022
* origin:
  chore: disable debug/pprof interface (apache#2339)
  feat: add upstream id in form (apache#2321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/debug/pprof/ this api un auth
6 participants