fix plugins display in list of routes #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 74.27% 76.42% +2.15%
==========================================
Files 201 139 -62
Lines 7833 3759 -4074
Branches 874 877 +3
==========================================
- Hits 5818 2873 -2945
+ Misses 1712 886 -826
+ Partials 303 0 -303
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi, could you add some comparison pictures to facilitate community members' review PR? (Because we don't have an online preview yet 😢) |
My apologize for not replying soon. This following might show difference between fix bugs and before. Tagscause of tags don't have attribute width, it might not be displayed correctly when the screen width is too short Before
After
Tagsdue to plugins have neither width nor override render function. Before
After
|
Baoyuantop
approved these changes
Jan 19, 2023
LiteSun
reviewed
Jan 19, 2023
delete useless space. Co-authored-by: litesun <sunyi@apache.org>
LiteSun
approved these changes
Jan 27, 2023
Baoyuantop
pushed a commit
to Baoyuantop/apisix-dashboard
that referenced
this pull request
Mar 22, 2023
Co-authored-by: litesun <sunyi@apache.org>
Baoyuantop
added a commit
that referenced
this pull request
Mar 23, 2023
* chore: update the year in the NOTICE (#2726) fix: #2724 * fix plugins display in list of routes (#2704) Co-authored-by: litesun <sunyi@apache.org> * fix: plugin config page error (#2739) * fix: plugin disable invalid in API /plugin?all=true (#2737) * chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730) * fix: update URL of the online playground (#2760) * chore: update dependency (#2752) * chore: update dependency --------- Co-authored-by: rongxin <alinsran@apache.org> * fix: remove route name length limit (#2759) * fix: change regex template to optional in proxy write (#2762) * fix: ssl table expiration time display (#2763) * feat: add search functionality for id, host, and description fields (#2750) Co-authored-by: Anil Durmus <anil.durmus@trendyol.com> * fix: disable global plugin invalid (#2757) * feat: support ipv6 in upstream nodes (#2766) * fix: upstream nodes metadata miss (#2773) * fix: remove ssl check in redirect https (#2770) --------- Co-authored-by: Shivam0500 <121167056+Shivam0500@users.noreply.github.com> Co-authored-by: incubator4 <aries0robin@gmail.com> Co-authored-by: litesun <sunyi@apache.org> Co-authored-by: Joanthan Chen <mscb402@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JunXu Chen <chenjunxu6@gmail.com> Co-authored-by: Xin Rong <alinsran333@gmail.com> Co-authored-by: rongxin <alinsran@apache.org> Co-authored-by: Anil Baki Durmus <anldrms34@gmail.com> Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
pluginstoResponseBodylabelsandplugins(Due to without width, these columns might not display as expected)pluginscolumns.Related issues
fix/resolve #2665
Checklist:
Why not test cases and corresponding document? Cause of it just was a bug fix.