Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin config page error #2739

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

Baoyuantop
Copy link
Contributor

@Baoyuantop Baoyuantop commented Feb 10, 2023

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2732

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #2739 (862b9c1) into master (4d26409) will decrease coverage by 8.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
- Coverage   76.40%   67.98%   -8.43%     
==========================================
  Files         139       39     -100     
  Lines        3759     1040    -2719     
  Branches      877      268     -609     
==========================================
- Hits         2872      707    -2165     
+ Misses        887      333     -554     
Flag Coverage Δ
frontend-e2e-test 67.98% <100.00%> (-8.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx 64.48% <100.00%> (-10.93%) ⬇️
web/src/components/Plugin/PluginPage.tsx 82.00% <100.00%> (-17.00%) ⬇️
web/src/helpers.tsx 19.67% <0.00%> (-57.38%) ⬇️
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) ⬇️
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) ⬇️
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) ⬇️
web/src/pages/Consumer/List.tsx 73.17% <0.00%> (-19.52%) ⬇️
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) ⬇️
web/src/app.tsx 87.87% <0.00%> (-12.13%) ⬇️
... and 108 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Baoyuantop Baoyuantop marked this pull request as ready for review February 13, 2023 08:13
Copy link
Member

@LiteSun LiteSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case needed

@Baoyuantop
Copy link
Contributor Author

test case needed

This error is caused by incompatible resources created in apisix, and there is no DP testing in front-end E2E yet.

@Baoyuantop Baoyuantop merged commit 9b1f8f0 into apache:master Feb 20, 2023
@Baoyuantop Baoyuantop deleted the fix-plugin-error branch February 20, 2023 09:43
Baoyuantop added a commit to Baoyuantop/apisix-dashboard that referenced this pull request Mar 22, 2023
Baoyuantop added a commit that referenced this pull request Mar 23, 2023
* chore: update the year in the  NOTICE (#2726)

fix: #2724

* fix plugins display in list of routes (#2704)

Co-authored-by: litesun <sunyi@apache.org>

* fix: plugin config page error (#2739)

* fix: plugin disable invalid in API /plugin?all=true (#2737)

* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730)

* fix: update URL of the online playground (#2760)

* chore: update dependency (#2752)

* chore: update dependency

---------

Co-authored-by: rongxin <alinsran@apache.org>

* fix: remove route name length limit (#2759)

* fix: change regex template to optional in proxy write (#2762)

* fix: ssl table expiration time display (#2763)

* feat: add search functionality for id, host, and description fields (#2750)

Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>

* fix: disable global plugin invalid (#2757)

* feat: support ipv6 in upstream nodes (#2766)

* fix: upstream nodes metadata miss (#2773)

* fix: remove ssl check in redirect https (#2770)

---------

Co-authored-by: Shivam0500 <121167056+Shivam0500@users.noreply.github.com>
Co-authored-by: incubator4 <aries0robin@gmail.com>
Co-authored-by: litesun <sunyi@apache.org>
Co-authored-by: Joanthan Chen <mscb402@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JunXu Chen <chenjunxu6@gmail.com>
Co-authored-by: Xin Rong <alinsran333@gmail.com>
Co-authored-by: rongxin <alinsran@apache.org>
Co-authored-by: Anil Baki Durmus <anldrms34@gmail.com>
Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard return blank pange when edit plugins
4 participants