Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Plugin disable invalid in API /plugin?all=true #2737

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

mscb402
Copy link
Contributor

@mscb402 mscb402 commented Feb 9, 2023

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

I tried to disable the plugin in the configuration plugins content of conf.yaml when answering the issue question and it didn't work. After reading the code in the plugin section, I found that in a previously submitted PR #1592, the judgment of whether the plugin is enabled or not was removed. So this PR I fixes the problem and support disabling plugins in conf.yaml plugins.

Related issues

fix/resolve #2735

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #2737 (5e41893) into master (4d26409) will decrease coverage by 2.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   76.40%   74.29%   -2.11%     
==========================================
  Files         139      201      +62     
  Lines        3759     7840    +4081     
  Branches      877      877              
==========================================
+ Hits         2872     5825    +2953     
- Misses        887     1712     +825     
- Partials        0      303     +303     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.40% <100.00%> (?)
backend-unit-test 50.11% <100.00%> (?)
frontend-e2e-test 76.42% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/schema/plugin.go 100.00% <100.00%> (ø)
api/internal/core/entity/entity.go 90.90% <0.00%> (ø)
api/internal/handler/upstream/upstream.go 86.58% <0.00%> (ø)
api/cmd/root.go 69.56% <0.00%> (ø)
api/internal/core/store/validate.go 71.64% <0.00%> (ø)
api/internal/handler/label/label.go 86.20% <0.00%> (ø)
api/internal/core/migrate/conflict.go 80.00% <0.00%> (ø)
api/internal/utils/consts/api_error.go 50.00% <0.00%> (ø)
api/internal/core/storage/etcd.go 54.38% <0.00%> (ø)
api/internal/core/server/http.go 56.52% <0.00%> (ø)
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mscb402 mscb402 marked this pull request as ready for review February 10, 2023 06:35
@mscb402
Copy link
Contributor Author

mscb402 commented Feb 14, 2023

@bzp2010 @tokers do you have time help me to review this

@Baoyuantop Baoyuantop merged commit 0b19a18 into apache:master Feb 22, 2023
@mscb402 mscb402 deleted the fix/plugin_enable_error branch February 22, 2023 01:39
Baoyuantop pushed a commit to Baoyuantop/apisix-dashboard that referenced this pull request Mar 22, 2023
Baoyuantop added a commit that referenced this pull request Mar 23, 2023
* chore: update the year in the  NOTICE (#2726)

fix: #2724

* fix plugins display in list of routes (#2704)

Co-authored-by: litesun <sunyi@apache.org>

* fix: plugin config page error (#2739)

* fix: plugin disable invalid in API /plugin?all=true (#2737)

* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730)

* fix: update URL of the online playground (#2760)

* chore: update dependency (#2752)

* chore: update dependency

---------

Co-authored-by: rongxin <alinsran@apache.org>

* fix: remove route name length limit (#2759)

* fix: change regex template to optional in proxy write (#2762)

* fix: ssl table expiration time display (#2763)

* feat: add search functionality for id, host, and description fields (#2750)

Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>

* fix: disable global plugin invalid (#2757)

* feat: support ipv6 in upstream nodes (#2766)

* fix: upstream nodes metadata miss (#2773)

* fix: remove ssl check in redirect https (#2770)

---------

Co-authored-by: Shivam0500 <121167056+Shivam0500@users.noreply.github.com>
Co-authored-by: incubator4 <aries0robin@gmail.com>
Co-authored-by: litesun <sunyi@apache.org>
Co-authored-by: Joanthan Chen <mscb402@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JunXu Chen <chenjunxu6@gmail.com>
Co-authored-by: Xin Rong <alinsran333@gmail.com>
Co-authored-by: rongxin <alinsran@apache.org>
Co-authored-by: Anil Baki Durmus <anldrms34@gmail.com>
Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>
@holate holate mentioned this pull request Nov 15, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

目前apisix有众多的插件,我应该如何去屏蔽掉一些插件,不在页面上显示出来。
5 participants