Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ipv6 in upstream nodes #2766

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2449

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #2766 (9577971) into master (7c264b0) will decrease coverage by 2.08%.
The diff coverage is 54.34%.

❗ Current head 9577971 differs from pull request most recent head 2ac94cf. Consider uploading reports for the commit 2ac94cf to get more accurate results

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   76.42%   74.35%   -2.08%     
==========================================
  Files         139      201      +62     
  Lines        3759     7872    +4113     
  Branches      877      886       +9     
==========================================
+ Hits         2873     5853    +2980     
- Misses        886     1709     +823     
- Partials        0      310     +310     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.15% <20.83%> (?)
backend-unit-test 49.92% <37.50%> (?)
frontend-e2e-test 76.81% <72.72%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/entity/entity.go 90.90% <ø> (ø)
api/internal/handler/route/route.go 78.11% <0.00%> (ø)
api/internal/handler/service/service.go 90.62% <0.00%> (ø)
api/internal/handler/upstream/upstream.go 84.52% <0.00%> (ø)
web/src/components/Upstream/components/Nodes.tsx 100.00% <ø> (ø)
web/src/pages/Plugin/List.tsx 100.00% <ø> (+3.70%) ⬆️
web/src/pages/Route/List.tsx 76.60% <ø> (+1.16%) ⬆️
.../src/pages/Route/components/Step1/ProxyRewrite.tsx 94.82% <ø> (ø)
web/src/pages/Service/List.tsx 94.87% <ø> (ø)
web/src/pages/Upstream/List.tsx 95.00% <ø> (ø)
... and 6 more

... and 60 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Baoyuantop Baoyuantop marked this pull request as ready for review March 14, 2023 01:17
@Baoyuantop Baoyuantop merged commit bf61459 into apache:master Mar 16, 2023
@Baoyuantop Baoyuantop deleted the fix-host-input branch March 16, 2023 08:54
Baoyuantop added a commit to Baoyuantop/apisix-dashboard that referenced this pull request Mar 22, 2023
Baoyuantop added a commit that referenced this pull request Mar 23, 2023
* chore: update the year in the  NOTICE (#2726)

fix: #2724

* fix plugins display in list of routes (#2704)

Co-authored-by: litesun <sunyi@apache.org>

* fix: plugin config page error (#2739)

* fix: plugin disable invalid in API /plugin?all=true (#2737)

* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730)

* fix: update URL of the online playground (#2760)

* chore: update dependency (#2752)

* chore: update dependency

---------

Co-authored-by: rongxin <alinsran@apache.org>

* fix: remove route name length limit (#2759)

* fix: change regex template to optional in proxy write (#2762)

* fix: ssl table expiration time display (#2763)

* feat: add search functionality for id, host, and description fields (#2750)

Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>

* fix: disable global plugin invalid (#2757)

* feat: support ipv6 in upstream nodes (#2766)

* fix: upstream nodes metadata miss (#2773)

* fix: remove ssl check in redirect https (#2770)

---------

Co-authored-by: Shivam0500 <121167056+Shivam0500@users.noreply.github.com>
Co-authored-by: incubator4 <aries0robin@gmail.com>
Co-authored-by: litesun <sunyi@apache.org>
Co-authored-by: Joanthan Chen <mscb402@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JunXu Chen <chenjunxu6@gmail.com>
Co-authored-by: Xin Rong <alinsran333@gmail.com>
Co-authored-by: rongxin <alinsran@apache.org>
Co-authored-by: Anil Baki Durmus <anldrms34@gmail.com>
Co-authored-by: Anil Durmus <anil.durmus@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a IPv6 address in upstream nodes->host failed
4 participants