Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support variable in ApisixRoute exprs scope #1466

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Nov 17, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan marked this pull request as ready for review November 17, 2022 06:18
@codecov-commenter
Copy link

Codecov Report

Merging #1466 (4782a05) into master (5570d28) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   41.35%   41.23%   -0.13%     
==========================================
  Files          82       82              
  Lines        7261     7283      +22     
==========================================
  Hits         3003     3003              
- Misses       3911     3933      +22     
  Partials      347      347              
Impacted Files Coverage Δ
pkg/providers/apisix/translation/apisix_route.go 31.51% <0.00%> (-0.27%) ⬇️
...providers/gateway/translation/gateway_httproute.go 48.61% <0.00%> (-3.89%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

feature request: ApisixRoute resources use vars in Route
4 participants