Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: socket file permission #55

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Conversation

SkyeYoung
Copy link
Member

fix: #53

changes:

  • chmod socket file permission to 766

cc @spacewander

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #55 (2bc1818) into master (3de14f8) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   91.72%   91.62%   -0.10%     
==========================================
  Files          11       11              
  Lines         749      752       +3     
==========================================
+ Hits          687      689       +2     
- Misses         62       63       +1     
Impacted Files Coverage Δ
apisix/runner/server/server.py 51.42% <66.66%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# from writing to it if the APISIX is run under root.
os.chmod(self.fd, 0o766)
if os.stat(self.fd).st_mode & 0xfff != 0o766:
raise Exception("can't change mode for unix socket permission to 766")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CI configuration so the e2e test can pass?
We need to adjust the port of Admin API.

@SkyeYoung
Copy link
Member Author

SkyeYoung commented Sep 18, 2022 via email

@spacewander
Copy link
Member

Maybe we can deal with codecov in the next PR?

@bzp2010 bzp2010 merged commit 250b936 into apache:master Sep 19, 2022
@adamckay adamckay mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants