Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hidding real message when password or username is error #6707

Merged
merged 2 commits into from
Mar 27, 2022
Merged

fix: hidding real message when password or username is error #6707

merged 2 commits into from
Mar 27, 2022

Conversation

liangliang4ward
Copy link
Contributor

@liangliang4ward liangliang4ward commented Mar 24, 2022 •
edited
Loading

Description

about auth-plugin when have password and username hidding real message when password or username is not match

Fixes #6703

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

starsz
starsz previously approved these changes Mar 24, 2022
View reviewed changes
membphis
membphis previously approved these changes Mar 24, 2022
View reviewed changes
tzssangglass
tzssangglass previously approved these changes Mar 24, 2022
View reviewed changes
moonming
moonming requested changes Mar 24, 2022
View reviewed changes
apisix/plugins/basic-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/basic-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/ldap-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/ldap-auth.lua Outdated Show resolved Hide resolved
@spacewander
Copy link
Member

Hi @liangliang4ward, you need to use:

Fixes #6703

but not

Fixes # [(issue)](https://github.com/apache/apisix/issues/6703)

in the link

@liangliang4ward
Copy link
Contributor Author

Hi @liangliang4ward, you need to use:

Fixes #6703

but not

Fixes # [(issue)](https://github.com/apache/apisix/issues/6703)

in the link

ok

@membphis membphis requested a review from moonming March 26, 2022 13:55
@membphis membphis merged commit ee7771b into apache:master Mar 27, 2022
@membphis
Copy link
Member

many thx @liangliang4ward

@liangliang4ward liangliang4ward deleted the fix/hiding-real-message branch March 29, 2022 01:10
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@liangliang4ward @Liu-Junlin
fix: hidding real message when password or username is error (apache#…
c857253 
…6707)

Co-authored-by: root <root@DESKTOP-QE043PO.localdomain>
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@liangliang4ward @spacewander
fix: hidding real message when password or username is error (#6707)
c902d3c 
Co-authored-by: root <root@DESKTOP-QE043PO.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslie-tsang leslie-tsang leslie-tsang approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@moonming moonming moonming approved these changes

@starsz starsz starsz left review comments

@membphis membphis membphis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: As a user, when use basic-auth if password or username is error I don't want tell truth message
7 participants
@liangliang4ward @spacewander @membphis @starsz @moonming @tzssangglass @leslie-tsang